#375 Fix newline code normalization in UTF-8 encoded file input #376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has fixed the newline code normalization of CR+LF into LF contained in a given file for deserialization, which is the root cause of the bug reported in the issue #375.
Before the fix, CR+LF newline codes were normalized mistakenly into CR, which broke the subsequent deserialization process which intentionally ignores the existence of CR for optimization.
By correcting the normalization logic, CR+LF are now successfully normalized into LF.
Furthermore, since the normalized input value checks were somehow dropped in the input_adapter module test cases, the appropriate checks have also been added.
Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdef
s or other means.