Skip to content

#375 Fix newline code normalization in UTF-8 encoded file input #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Aug 19, 2024

This PR has fixed the newline code normalization of CR+LF into LF contained in a given file for deserialization, which is the root cause of the bug reported in the issue #375.
Before the fix, CR+LF newline codes were normalized mistakenly into CR, which broke the subsequent deserialization process which intentionally ignores the existence of CR for optimization.
By correcting the normalization logic, CR+LF are now successfully normalized into LF.

Furthermore, since the normalized input value checks were somehow dropped in the input_adapter module test cases, the appropriate checks have also been added.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Aug 19, 2024
@fktn-k fktn-k added this to the Release v0.3.11 milestone Aug 19, 2024
@fktn-k fktn-k self-assigned this Aug 19, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 5fcb72cd05ad92a8722e5254980edfae2685ae27.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr376.zip
ID 1828296426
URL https://github.com/fktn-k/fkYAML/actions/runs/10456730369/artifacts/1828296426

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10456730369

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10442147415: 0.0%
Covered Lines: 3971
Relevant Lines: 3971

💛 - Coveralls

@fktn-k fktn-k merged commit 0b52cf0 into develop Aug 19, 2024
166 checks passed
@fktn-k fktn-k deleted the bugfix/375_fix_utf8_newline_normalization_in_file_input branch August 19, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants