Skip to content

Allow the document end marker omitted #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Aug 18, 2024

The current fkYAML doesn't allow the document end marker (...) omitted before a new YAML document like the following YAML snippet (extracted from the yaml-test-suite's 35KP/in.yaml):

--- !!map
? a
: b
--- !!seq
- !!str c
--- !!str
d
e
# Note that the last multiline plain scalar isn't supported by fkYAML yet.

Parsing the above YAML with fkYAML causes a false parse error which says "invalid end-of-directives marker (---) found in the contents.".
To resolve the false error, this PR has changed the implementation to allow the document end marker omitted, and the library thus assumes no directives preceeded in the next YAML document instead.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Aug 18, 2024
@fktn-k fktn-k added this to the Release v0.3.11 milestone Aug 18, 2024
@fktn-k fktn-k self-assigned this Aug 18, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit b9676bc1151c65aae3310ad170c58a2ccda94ce0.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr374.zip
ID 1824809610
URL https://github.com/fktn-k/fkYAML/actions/runs/10441822201/artifacts/1824809610

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10441822201

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10440760538: 0.0%
Covered Lines: 3969
Relevant Lines: 3969

💛 - Coveralls

@fktn-k fktn-k merged commit 150286e into develop Aug 18, 2024
166 checks passed
@fktn-k fktn-k deleted the allow_no_document_end_marker_before_new_yaml_doc branch August 18, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants