Skip to content

Fix bug in serializing alias keys #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Jun 16, 2024

The current serializer changes alias names when they are used as a mapping key.
For example, serializing the following YAML snippet:

foo: &A bar
*A : baz

the serializer emits the following wrong result since alias names can contain colons:

foo: &A bar
*A: baz # alias name mistakenly becomes "*A:".

So, this PR has fixed the above issue and now the serializer emits correct alias keys.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Jun 16, 2024
@fktn-k fktn-k added this to the Release v0.3.10 milestone Jun 16, 2024
@fktn-k fktn-k self-assigned this Jun 16, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit c7eab4f7359e771af0b150eb95fd993a628edc94.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr364.zip
ID 1605474256
URL https://github.com/fktn-k/fkYAML/actions/runs/9532833656/artifacts/1605474256

@coveralls
Copy link

coveralls commented Jun 16, 2024

Pull Request Test Coverage Report for Build 9532833656

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9532729985: 0.0%
Covered Lines: 3929
Relevant Lines: 3929

💛 - Coveralls

@fktn-k fktn-k merged commit a0b26b7 into develop Jun 16, 2024
@fktn-k fktn-k deleted the fix_serialize_alias_keys branch June 16, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants