Skip to content

Support Intel icpx compiler #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 15, 2024
Merged

Support Intel icpx compiler #360

merged 4 commits into from
Jun 15, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Jun 15, 2024

This PR adds support of icpx compilers.
Intel compilers use fast floating points by default and (sometimes too aggressively) warn against the usages of nans and infinities.
fkYAML, however, uses nans and infinities to manage YAML node values.
So, in building the unit test app, -fp-model=precise is used as a workaround.

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the ci related to CI jobs label Jun 15, 2024
@fktn-k fktn-k added this to the Release v0.3.10 milestone Jun 15, 2024
@fktn-k fktn-k self-assigned this Jun 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 15, 2024 •
edited
Loading

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 4bd679902f37e6bbf81c973d1422fd744f50fd7e.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr360.zip
ID 1604254389
URL https://github.com/fktn-k/fkYAML/actions/runs/9525539221/artifacts/1604254389

@coveralls
Copy link

coveralls commented Jun 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9525236334

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9484098931: 0.0%
Covered Lines: 3888
Relevant Lines: 3888
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9525326387

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9484098931: 0.0%
Covered Lines: 3888
Relevant Lines: 3888
💛 - Coveralls

@fktn-k fktn-k force-pushed the support_intel_compiler branch from 00d7a9b to 02fda80 Compare June 15, 2024 04:22
@coveralls
Copy link

coveralls commented Jun 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9525463156

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9484098931: 0.0%
Covered Lines: 3888
Relevant Lines: 3888
💛 - Coveralls

@fktn-k fktn-k force-pushed the support_intel_compiler branch from 02fda80 to 4bd6799 Compare June 15, 2024 04:37
@coveralls
Copy link

coveralls commented Jun 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9525539221

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9484098931: 0.0%
Covered Lines: 3888
Relevant Lines: 3888
💛 - Coveralls

@fktn-k fktn-k merged commit 6ee80b0 into develop Jun 15, 2024
@fktn-k fktn-k deleted the support_intel_compiler branch June 15, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fktn-k fktn-k

Labels
ci related to CI jobs
Projects
None yet
Milestone
Release v0.3.10
Development

Successfully merging this pull request may close these issues.
2 participants
@fktn-k @coveralls