Skip to content

Fix parse error on empty flow containers #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented May 27, 2024

As reported in the issue #347, the latest parser mistakenly emits the parse errors on empty flow containers like:

foo: {}
bar: []

They are caused because the PR #350 lacked implementation for empty flow containers.
So, this PR has fixed them by adding the missing implementation and added some test cases to validate the changes.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label May 27, 2024
@fktn-k fktn-k added this to the Release v0.3.8 milestone May 27, 2024
@fktn-k fktn-k self-assigned this May 27, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 01690f78a2f752bc1adc6729c73de12b51d788c3.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr351.zip
ID 1540759864
URL https://github.com/fktn-k/fkYAML/actions/runs/9254185815/artifacts/1540759864

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9254185815

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9247789643: 0.0%
Covered Lines: 3897
Relevant Lines: 3897

💛 - Coveralls

@fktn-k fktn-k merged commit 775f2f0 into develop May 27, 2024
@fktn-k fktn-k deleted the fix_parse_error_on_empty_flow_containers branch May 27, 2024 12:05
@fktn-k fktn-k mentioned this pull request May 27, 2024
2 tasks
@fktn-k fktn-k linked an issue May 27, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse error
2 participants