Skip to content

Fix wrong parse result from mappings containing the non-first block sequence #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented May 25, 2024

This PR has fixed wrong parse results from YAML which contains the non-first node pair whose value is a block sequence, like the YAML snippet in the issue #347 due to the wrong tracing back to a parent mapping node.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label May 25, 2024
@fktn-k fktn-k added this to the Release v0.3.8 milestone May 25, 2024
@fktn-k fktn-k self-assigned this May 25, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 03acfa568db6d9d6f15f76313d948cec501e53bf.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr348.zip
ID 1537712472
URL https://github.com/fktn-k/fkYAML/actions/runs/9237435489/artifacts/1537712472

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9237435489

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9148350741: 0.0%
Covered Lines: 3758
Relevant Lines: 3758

💛 - Coveralls

@fktn-k fktn-k merged commit e8a90ad into develop May 25, 2024
@fktn-k fktn-k deleted the bugfix/347_fix_trace_back_mappings branch May 25, 2024 18:44
@fktn-k fktn-k mentioned this pull request May 25, 2024
2 tasks
@fktn-k fktn-k linked an issue May 27, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse error
2 participants