Skip to content

Fix parse error on flow container keys #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 26, 2024
Merged

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented May 19, 2024

This PR has fixed parse errors on flow container keys like the following valid YAML snippet:

{foo: bar}: 123
[true,false]: 3.14

The root cause is that the fkYAML deserializer wrongly assumed that flow containers weren't used as a mapping key.
To validate the fix, the test suite has also been updated by adding several relevant test cases for the deserializer.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label May 19, 2024
@fktn-k fktn-k added this to the Release v0.3.8 milestone May 19, 2024
@fktn-k fktn-k self-assigned this May 19, 2024
Copy link

github-actions bot commented May 19, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 530a897d44896bc0a01177bdd5ecd942b2a45dc1.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr346.zip
ID 1538087095
URL https://github.com/fktn-k/fkYAML/actions/runs/9240012472/artifacts/1538087095

@coveralls
Copy link

coveralls commented May 19, 2024

Pull Request Test Coverage Report for Build 9240012472

Details

  • 148 of 148 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9237506365: 0.0%
Covered Lines: 3874
Relevant Lines: 3874

💛 - Coveralls

@fktn-k fktn-k force-pushed the fix_parse_flow_container_keys branch from 36209b4 to 5564dbd Compare May 25, 2024 18:59
@fktn-k fktn-k merged commit 32e551e into develop May 26, 2024
@fktn-k fktn-k deleted the fix_parse_flow_container_keys branch May 26, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants