Skip to content

Normalize newline codes in the input buffer #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 19, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented May 19, 2024

This PR has added the feature of normalizing newline codes in input buffers (LF and CR+LF codes to LF) in the input_adapter module and thus removed the handling of CR+LF codes implemented in the lexical_analyzer class.
The change will improve performance in scanning input buffers in the lexical_analyzer class since it no longer needs to take into account the existence of CR+LF codes contained in the target buffer.
The test suite has also been updated to validate the normalization feature.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label May 19, 2024
@fktn-k fktn-k added this to the Release v0.3.8 milestone May 19, 2024
@fktn-k fktn-k self-assigned this May 19, 2024
Copy link

github-actions bot commented May 19, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 96f3cd21b4d06d7969f6a87871388c4dbffc0b02.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr343.zip
ID 1516478399
URL https://github.com/fktn-k/fkYAML/actions/runs/9144636433/artifacts/1516478399

@coveralls
Copy link

coveralls commented May 19, 2024

Pull Request Test Coverage Report for Build 9144636433

Details

  • 55 of 55 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9115035026: 0.0%
Covered Lines: 3700
Relevant Lines: 3700

💛 - Coveralls

@fktn-k fktn-k merged commit d13210d into develop May 19, 2024
@fktn-k fktn-k deleted the normalize_newline_codes_in_input_buffer branch May 19, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants