Normalize newline codes in the input buffer #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has added the feature of normalizing newline codes in input buffers (LF and CR+LF codes to LF) in the
input_adapter
module and thus removed the handling of CR+LF codes implemented in thelexical_analyzer
class.The change will improve performance in scanning input buffers in the
lexical_analyzer
class since it no longer needs to take into account the existence of CR+LF codes contained in the target buffer.The test suite has also been updated to validate the normalization feature.
Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdef
s or other means.