Skip to content

Allow ':' adjacent to a flow mapping value right after a JSON-like key #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Jan 19, 2025

This PR makes changes to allow for a flow mapping value to be specified right after the ":" mapping value indicator if its key is JSON-like (surrounded by indicators like {}, [], "" or '') since the YAML specification allows that for JSON compatibility (see here).
With the changes, the following YAML (and minified JSON) is now parsed without any problem.

YAML

{
  "foo":true,
  'bar':false,
  {[1,2,3]:"baz"}:3.14
}

JSON (Minified)

{"foo",true,"bar":false,"baz":null}

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label Jan 19, 2025
@fktn-k fktn-k added this to the Release v0.4.2 milestone Jan 19, 2025
@fktn-k fktn-k self-assigned this Jan 19, 2025
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit dc1462a6a1146229754a705ea02b155e43330422.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr468.zip
ID 2452097324
URL https://github.com/fktn-k/fkYAML/actions/runs/12850237863/artifacts/2452097324

@fktn-k fktn-k merged commit 258b236 into develop Jan 19, 2025
163 checks passed
@fktn-k fktn-k deleted the allow_key_sep_adjacent_to_flow_map_val branch January 19, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant