Skip to content

support std::forward_list in from_node #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Dec 16, 2024

This PR adds support for std::forward_list in conversion from a basic_node by calling get_value() and get_value_inplace().
The documentation has also been updated according to the above change.

Furthermore, since the current test suite covers not 100% of lines/branches of the codebase (I just didn't check the coverage score), some test cases have been added. Now the test suite covers 100% of the lines/branches again!


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label Dec 16, 2024
@fktn-k fktn-k added this to the Release v0.4.1 milestone Dec 16, 2024
@fktn-k fktn-k self-assigned this Dec 16, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 1835401753f8d95d07fd594f171f885864e027d5.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr444.zip
ID 2326141189
URL https://github.com/fktn-k/fkYAML/actions/runs/12353587398/artifacts/2326141189

@fktn-k fktn-k merged commit ec133cd into develop Dec 16, 2024
163 checks passed
@fktn-k fktn-k deleted the support_forward_list_in_from_node branch December 16, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant