Skip to content

Add get_value_inplace API to basic_node #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 15, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Dec 15, 2024

This PR adds a new basic_node API get_value_inplace() which converts a basic_node value into a given type and writes the conversion result into a given output parameter.
Visit the documentation page for details.

Here are some brief notes for the get_value_inplace() API.

  • all the currently supported STL container/scalar types by get_value() are also supported by get_value_inplace() since internal implementation for conversions is shared.
  • not default constructible types can also be used
  • 1D, 2D and 3D C-style arrays are supported (more than 3 dimentional arrays are not)

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the new feature new feature possibly with public API changes label Dec 15, 2024
@fktn-k fktn-k added this to the Release v0.4.1 milestone Dec 15, 2024
@fktn-k fktn-k self-assigned this Dec 15, 2024
Copy link

github-actions bot commented Dec 15, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit a22eefa52970f6eef7baa4a21f05d2b4e155ed07.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr443.zip
ID 2323162898
URL https://github.com/fktn-k/fkYAML/actions/runs/12341058710/artifacts/2323162898

@fktn-k fktn-k merged commit 5aaa028 into develop Dec 15, 2024
163 checks passed
@fktn-k fktn-k deleted the inplace_getter_for_node_values branch December 15, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature new feature possibly with public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant