Skip to content

Fix round-trip issue in float serialization using scientific notation #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Dec 7, 2024

This PR fixes the issue which has been itroduced by the PR #407 and is reported here.
During the conversion from a floating point value to a string, ".0" is appended only when the following conditions are met:

  1. the floating point value is actually an integer
  2. no scientific notation is used for serialization

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Dec 7, 2024
@fktn-k fktn-k added this to the Release v0.4.0 milestone Dec 7, 2024
@fktn-k fktn-k self-assigned this Dec 7, 2024
Copy link

github-actions bot commented Dec 7, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit a6a257059d7352f25dd262e37dcd652f15ef5c8c.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr439.zip
ID 2290257408
URL https://github.com/fktn-k/fkYAML/actions/runs/12221491619/artifacts/2290257408

@fktn-k fktn-k changed the title Fix round-trip issue in float-to-string conversion using scientific notation Fix round-trip issue in float serialization using scientific notation Dec 7, 2024
@fktn-k fktn-k force-pushed the bugfix/405_float_serialization_using_scientific_notation branch from 2c5b015 to a6a2570 Compare December 8, 2024 11:44
@fktn-k fktn-k merged commit a5e73da into develop Dec 9, 2024
163 checks passed
@fktn-k fktn-k linked an issue Dec 10, 2024 that may be closed by this pull request
2 tasks
@fktn-k fktn-k deleted the bugfix/405_float_serialization_using_scientific_notation branch December 10, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinguishing floats and ints when writing to Yaml
1 participant