Skip to content

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Nov 24, 2024

As described in the YAML specification (7.1. Alias Nodes), any properties (anchor and tag) must not be specified to an alias node.
Although the library emits an error if a tag is specified to an alias node, it doesn't if an anchor is specified to an alias node.

&anchor foo: !!str *anchor # this is treated as an error.
---
&anchor foo: &anchor2 *anchor # this is not treated as an error, but it should be.

So, in this PR, the implementation has been fixed so the library would throws an parse_error if an anchor is specified to an alias node.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Nov 24, 2024
@fktn-k fktn-k added this to the Release v0.4.0 milestone Nov 24, 2024
@fktn-k fktn-k self-assigned this Nov 24, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 82fad59199774f06b688131b475961de124b8985.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr434.zip
ID 2229296137
URL https://github.com/fktn-k/fkYAML/actions/runs/11994504674/artifacts/2229296137

@fktn-k fktn-k changed the title Emit error if an anchor is specified to an alias node Emit error if an anchor is specified to an alias Nov 24, 2024
@fktn-k fktn-k merged commit ca34fe9 into develop Nov 24, 2024
155 checks passed
@fktn-k fktn-k deleted the emit_error_on_anchor_plus_alias branch November 24, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant