Stop throwing parse_error on string-to-int/float conversion failures if not forced with tag #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has fixed the issue reported in #428, that is, conversion failure from a string to either an integer or a floating point value throws a
parse_error
exception.The error should be recovered by treating the source scalar as a string scalar instead if the scalar is not tagged with
!!int
,!!float
or the equivalents.Note that conversion to null and boolean scalars are not considered as recoverable since their presentations are restricted to literals defined in the YAML spec, e.g.,
null
,true
orFalse
.Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdef
s or other means.