Skip to content

Exclude detail::unreachable() from coverage target #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Nov 16, 2024

This PR fixes unintended coverage loss due to no calls to the fkyaml::detail::unreachable() function.
Since the function is intended not to be called in any expected way, I've just excluded it from the coverage targets.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added this to the Release v0.3.14 milestone Nov 16, 2024
@fktn-k fktn-k self-assigned this Nov 16, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit fd51aeb06e2e9be713c93302ce002b04e6e4375b.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr426.zip
ID 2196335507
URL https://github.com/fktn-k/fkYAML/actions/runs/11868934411/artifacts/2196335507

@fktn-k fktn-k merged commit bd052ac into develop Nov 16, 2024
171 checks passed
@fktn-k fktn-k deleted the ignore_detail_unreachable_func_in_coverage branch November 16, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant