Skip to content

Disable -Wdeprecated-literal-operator warnings #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Oct 26, 2024

Newer versions of Clang (including AppleClang) compilers emits the -Wdeprecated-literal-operator warning against the definitions of literal operators fkyaml::literals::yaml_literals::operator "" _yaml() since a space before the suffix _yaml is deprecated from C++23.
Even if the active C++ standard is not C++23, however, compiling this library with the -Wdeprecated compile option causes the warning.
So, as a workaround, the -Wdeprecated-literal-operator warning is disabled while declaring _yaml literal operators.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

Copy link

github-actions bot commented Oct 26, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 73ac1ff36609717394c2d24d8a0208b3866fcb3b.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr417.zip
ID 2107799161
URL https://github.com/fktn-k/fkYAML/actions/runs/11533290229/artifacts/2107799161

@fktn-k fktn-k force-pushed the disable_deprecated_literal_operator_warning branch from 1a272ac to 3deb904 Compare October 26, 2024 16:02
@fktn-k fktn-k force-pushed the disable_deprecated_literal_operator_warning branch from 3deb904 to 73ac1ff Compare October 26, 2024 16:25
@fktn-k fktn-k self-assigned this Oct 26, 2024
@fktn-k fktn-k added the bug Something isn't working label Oct 26, 2024
@fktn-k fktn-k added this to the Release v0.3.14 milestone Oct 26, 2024
@fktn-k fktn-k merged commit 5f4f4dd into develop Oct 26, 2024
165 checks passed
@fktn-k fktn-k deleted the disable_deprecated_literal_operator_warning branch October 26, 2024 16:53
@fktn-k fktn-k mentioned this pull request Oct 27, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant