Fix wrong scalar value type detection from floating point value token #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current deserialization feature detects wrong scalar value types from token in some valid floating point value formats which contain the decimal point and/or the exponent:
1e-1
0e+1
All of them are valid according to the YAML standard 1.2, but the scalar_scanner class mistakenly detects them as either integer or string scalar value types.
This PR fixes such wrong detections and a number of test cases are also added to validate the changes.
Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdef
s or other means.