Skip to content

Fix wrong parse result from single scalar document #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Oct 14, 2024

This PR fixes wrong parse results from YAML documents which contains only one scalar (either flow or block) as described in the issue #406.
The root cause was that the current parser overestimates the root node is a mapping if the first node is a scalar.
So, the overestimation is corrected by determining the root node type based on the lexical token type, and some test cases are added to validate the chages.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Oct 14, 2024
@fktn-k fktn-k added this to the Release v0.3.13 milestone Oct 14, 2024
@fktn-k fktn-k self-assigned this Oct 14, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 2cd10d161dedc4e123c035612e21e616a941d0e4.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr411.zip
ID 2051602419
URL https://github.com/fktn-k/fkYAML/actions/runs/11321818006/artifacts/2051602419

@fktn-k fktn-k merged commit 56f9733 into develop Oct 14, 2024
165 checks passed
@fktn-k fktn-k deleted the bugfix/406_wrong_parse_result_from_single_scalar_document branch October 14, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant