Skip to content

Fix some typos in strings and comments #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2024
Merged

Fix some typos in strings and comments #408

merged 4 commits into from
Oct 6, 2024

Conversation

sndth
Copy link
Contributor

@sndth sndth commented Oct 5, 2024

This PR fixes several typos found in a few strings as well as in many comments, but it does not affect the code's functionality in any way. There are many more typos, and I will try to fix some more.

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@sndth sndth requested a review from fktn-k as a code owner October 5, 2024 13:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2024 •
edited
Loading

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 9de85aea08517b8f5cd3cc19465fa64391eabee5.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr408.zip
ID 2020554080
URL https://github.com/fktn-k/fkYAML/actions/runs/11201175332/artifacts/2020554080

@sndth sndth mentioned this pull request Oct 5, 2024
Open
2 tasks
fktn-k
fktn-k requested changes Oct 6, 2024
View reviewed changes
Copy link
Owner

@fktn-k fktn-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sndth
Thanks for fixing so many typos and gramatical mistakes.
I requested a tiny change, but the others look good to me.

fktn-k
fktn-k approved these changes Oct 6, 2024
View reviewed changes
Copy link
Owner

@fktn-k fktn-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fktn-k
Copy link
Owner

fktn-k commented Oct 6, 2024

@sndth
Let me know when you're done with all fixes.

@sndth
Copy link
Contributor Author

sndth commented Oct 6, 2024

Currently that's all!

@fktn-k
Copy link
Owner

fktn-k commented Oct 6, 2024

@sndth
OK. Thanks a lot!
I'll merge the changes.

@fktn-k fktn-k merged commit ca4bcfe into fktn-k:develop Oct 6, 2024
165 checks passed
@fktn-k fktn-k added this to the Release v0.3.13 milestone Oct 6, 2024
@fktn-k fktn-k added the documentation Improvements or additions to documentation label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fktn-k fktn-k fktn-k approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Release v0.3.13
Development

Successfully merging this pull request may close these issues.
2 participants
@sndth @fktn-k