Skip to content

Fix float scalar serialization when a float is actually an integer #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Oct 5, 2024

This PR fixes #405 by appending ".0" during float scalar serialization when a float is actually an integer. Without the appending, the serialization result would be interpreted as an integer scalar on using it as the input of deserialization.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Oct 5, 2024
@fktn-k fktn-k added this to the Release v0.3.13 milestone Oct 5, 2024
@fktn-k fktn-k self-assigned this Oct 5, 2024
Copy link

github-actions bot commented Oct 5, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit d722ff4bfe85e9e1d3c07c7d2e4c89338bbae650.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr407.zip
ID 2018243347
URL https://github.com/fktn-k/fkYAML/actions/runs/11188991703/artifacts/2018243347

@fktn-k fktn-k merged commit 9d7a3f5 into develop Oct 5, 2024
165 checks passed
@fktn-k fktn-k deleted the bugfix/405_fix_float_roundtrip_issue_in_serialization branch October 5, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinguishing floats and ints when writing to Yaml
1 participant