Skip to content

Fix compile warnings/errors when benchmarker app is compiled with msvc #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Sep 25, 2024

This PR has fixed warnings and errors when compiling the benchmarking app with MSVC compilers and made it just work.
No other changes have been made.
No benchmarking results on Windows is uploaded yet, and please hold on for a while.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Sep 25, 2024
@fktn-k fktn-k added this to the Release v0.3.13 milestone Sep 25, 2024
@fktn-k fktn-k self-assigned this Sep 25, 2024
@fktn-k fktn-k merged commit a1f2915 into develop Sep 25, 2024
93 checks passed
@fktn-k fktn-k deleted the fix_benchmarker_compile_error_with_msvc branch September 25, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant