Release v0.18.0 #1242
Release v0.18.0 #1242
Conversation
af30535 to
922886e
Compare
| - Updated the documentation for integration tests. | ||
| - Fixed high CPU usage before guest network interface is brought up (GitHub |
There was a problem hiding this comment.
I personally do not like the mentioning of the Github issue and I do not see value added. :( We have not done it until now and if we do it now, does that mean we will do it for every release?
There was a problem hiding this comment.
Hmm.. I think it'd be cool to have the issue number here so people can easily find it for more details.
But like @dianpopa said, if we do this here we need to be consistent and add it for every Fixed entry and every Added entry where we can reference an issue.
There was a problem hiding this comment.
I found mentioning the GitHub issue helpful for traceability reasons. The value that I see added is that one may look up more detailed information pertaining to a particular change (i.e. fix/change/addition). Without the GitHub reference, I find gathering that information to be much more challenging.
There was a problem hiding this comment.
I'm fine with having it, but let's be consistent. At the very least, the
- New device: virtio-vsock, backed by Unix domain sockets. See
docs/vsock.md.
entry needs the GitHub issue as well. A lot of the early design details are in issue #650
922886e to
d0d7bf8
Compare
| - Updated the documentation for integration tests. | ||
| - Fixed high CPU usage before guest network interface is brought up (GitHub |
There was a problem hiding this comment.
I'm fine with having it, but let's be consistent. At the very least, the
- New device: virtio-vsock, backed by Unix domain sockets. See
docs/vsock.md.
entry needs the GitHub issue as well. A lot of the early design details are in issue #650
|
Also rebase on top of master since you're changing files anyway (save some CI time). |
d0d7bf8 to
f914d20
Compare
Fixed a couple of typos in `docs/vsock.md`. Signed-off-by: Dan Horobeanu <dhr@amazon.com>
Updated `CHANGELOG.md` with the user-facing changes merged since v0.17.0. Signed-off-by: Dan Horobeanu <dhr@amazon.com>
Ran `devtool prepare_release` for new version v0.18.0. Signed-off-by: Dan Horobeanu <dhr@amazon.com>
f914d20 to
2f633c0
Compare
Reason for This PR
Release v0.18.0.
Description of Changes
docs/vsock.md.CHANGELOG.mdwith all user-facing changes since v0.17.0.CHANGELOG.md(line length) formatting.devtool prepare_release.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
git commit -s).clearly provided.
doc changes are included in this PR. Docs in scope are all
*.mdfileslocated either in the repository root, or in the
docs/directory.code is included in this PR.
reflected in
firecracker/swagger.yaml.this PR have user impact and have been added to the
CHANGELOG.mdfile.