Skip to content

Conversation

bchalios
Copy link
Contributor

@bchalios bchalios commented Sep 3, 2024

Changes

Change resources/rebuild.sh to not re-build 4.14 kernels. Also, drop various fixtures for 4.14 kernels in the CI and switch to 5.10 wherever the default was 4.14.

Reason

4.14 guest is now deprecated.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

Change resources/rebuild.sh to not re-build 4.14 kernels. Also, drop
various fixtures for 4.14 kernels in the CI and switch to 5.10 wherever
the default was 4.14.

Signed-off-by: Babis Chalios <bchalios@amazon.es>
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (eb4540c) to head (15a9d9a).
Report is 87 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4778   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files         249      249           
  Lines       27460    27460           
=======================================
  Hits        23160    23160           
  Misses       4300     4300           
Flag Coverage Δ
5.10-c5n.metal 84.56% <ø> (+<0.01%) ⬆️
5.10-m5n.metal 84.54% <ø> (ø)
5.10-m6a.metal 83.83% <ø> (ø)
5.10-m6g.metal 80.91% <ø> (ø)
5.10-m6i.metal 84.54% <ø> (-0.01%) ⬇️
5.10-m7g.metal 80.91% <ø> (ø)
6.1-c5n.metal 84.56% <ø> (-0.01%) ⬇️
6.1-m5n.metal 84.54% <ø> (-0.01%) ⬇️
6.1-m6a.metal 83.83% <ø> (ø)
6.1-m6g.metal 80.90% <ø> (ø)
6.1-m6i.metal 84.54% <ø> (+<0.01%) ⬆️
6.1-m7g.metal 80.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roypat roypat mentioned this pull request Sep 16, 2024
9 tasks
@pb8o
Copy link
Contributor

pb8o commented Sep 17, 2024

Superseded by #4804

@pb8o pb8o closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants