-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
Priority: LowIndicates that an issue or pull request should be resolved behind issues or pull requests labelled `Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `Status: WIPIndicates that an issue is currently being worked on or triagedIndicates that an issue is currently being worked on or triagedType: EnhancementIndicates new feature requestsIndicates new feature requests
Description
Per comment:
firecracker/devices/src/virtio/net.rs
Lines 153 to 154 in 99a0267
// TODO(smbarber): http://crbug.com/753630 | |
// Remove once MRG_RXBUF is supported and this variable is actually used. |
Please see relevant snipper from virtio spec:
"5.1.6.3.1 Driver Requirements: Setting Up Receive Buffers
If VIRTIO_NET_F_MRG_RXBUF is not negotiated:
If VIRTIO_NET_F_GUEST_TSO4, VIRTIO_NET_F_GUEST_TSO6 or VIRTIO_NET_F_GUEST_UFO are negotiated, the driver SHOULD populate the receive queue(s) with buffers of at least 65562 bytes.
Otherwise, the driver SHOULD populate the receive queue(s) with buffers of at least 1526 bytes.
If VIRTIO_NET_F_MRG_RXBUF is negotiated, each buffer MUST be at greater than the size of the struct virtio_net_hdr."
Metadata
Metadata
Labels
Priority: LowIndicates that an issue or pull request should be resolved behind issues or pull requests labelled `Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `Status: WIPIndicates that an issue is currently being worked on or triagedIndicates that an issue is currently being worked on or triagedType: EnhancementIndicates new feature requestsIndicates new feature requests