-
Notifications
You must be signed in to change notification settings - Fork 23
feat(salesforce): add Salesforce data provider #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you @mogery, I will review it as soon as I can tomorrow! |
@mogery quick question, what settings did you use for your Salesforce connected (oauth) app? |
I created a "Connected App" with "Enable OAuth Settings" checked. Used the Nango callback URL and enabled the "Full access (full)" and "Perform requests at any time (refresh_token, offline_access)" scopes. Then I got the client ID and secret by clicking on the "Manage Consumer Details" button that comes up after saving the app. |
Gotcha, thank you! I am trying to figure out which roles we actually need instead of asking for full access. |
ah! gimme a sec, i think i can narrow it down based on the docs... |
You only need the following:
And in Nango only (Btw, editing an integration is broken in Nango for some reason, I had to delete my existing one and remake it.) |
Thank you! @mogery and yea I noticed that and they told me that they just fixed it haha! |
It worked! Looks great! Thank you again! @mogery |
/tip $10 |
🎉🎈 @mogery has been awarded $10! 🎈🎊 |
Busted on the Confluence test copy paste 🙈 Thank you! |
Closes #15
/claim #15
This PR adds a Salesforce data provider, just like described in #15. It was tested with Nango connected to a Salesforce Developer Edition instance, which has enough seeded data to meaningfully pass the written tests, except for the knowledgebase.
Testing the knowledgebase requires additional setup that you can do in the Service Setup menu. You must also create at least one knowledgebase article for tests to pass. The
knowledge_prefix
option is needed to support some legacy Salesforce Classic installations. (Salesforce Knowledge is a huge mess.)For all modes, the
content
is the title and description of the record, and a lot more data is available in the metadata fields. An exception to this is thearticles
mode, where thecontent
is the article's title and actual content, formatted with HTML. (The API is kinda weird for this one, though the HTML tags are only like<em>
and<img>
, so nothing complex.)