Skip to content

Conversation

mogery
Copy link
Member

@mogery mogery commented Feb 6, 2024

Closes #15
/claim #15

This PR adds a Salesforce data provider, just like described in #15. It was tested with Nango connected to a Salesforce Developer Edition instance, which has enough seeded data to meaningfully pass the written tests, except for the knowledgebase.

Testing the knowledgebase requires additional setup that you can do in the Service Setup menu. You must also create at least one knowledgebase article for tests to pass. The knowledge_prefix option is needed to support some legacy Salesforce Classic installations. (Salesforce Knowledge is a huge mess.)

For all modes, the content is the title and description of the record, and a lot more data is available in the metadata fields. An exception to this is the articles mode, where the content is the article's title and actual content, formatted with HTML. (The API is kinda weird for this one, though the HTML tags are only like <em> and <img>, so nothing complex.)

@nickscamara
Copy link
Member

Thank you @mogery, I will review it as soon as I can tomorrow!

@nickscamara
Copy link
Member

@mogery quick question, what settings did you use for your Salesforce connected (oauth) app?

@mogery
Copy link
Member Author

mogery commented Feb 7, 2024

@mogery quick question, what settings did you use for your Salesforce connected (oauth) app?

I created a "Connected App" with "Enable OAuth Settings" checked. Used the Nango callback URL and enabled the "Full access (full)" and "Perform requests at any time (refresh_token, offline_access)" scopes.

Screenshot 2024-02-07 at 20 36 09

Then I got the client ID and secret by clicking on the "Manage Consumer Details" button that comes up after saving the app.

Screenshot 2024-02-07 at 20 36 32

More info here.

@nickscamara
Copy link
Member

Gotcha, thank you! I am trying to figure out which roles we actually need instead of asking for full access.

@mogery
Copy link
Member Author

mogery commented Feb 7, 2024

Gotcha, thank you! I am trying to figure out which roles we actually need instead of asking for full access.

ah! gimme a sec, i think i can narrow it down based on the docs...

@mogery
Copy link
Member Author

mogery commented Feb 7, 2024

I am trying to figure out which roles we actually need instead of asking for full access.

You only need the following:

Manage user data via APIs (api)
Perform requests at any time (refresh_token, offline_access)

And in Nango only api and offline_access.

(Btw, editing an integration is broken in Nango for some reason, I had to delete my existing one and remake it.)

@nickscamara
Copy link
Member

Thank you! @mogery and yea I noticed that and they told me that they just fixed it haha!

@nickscamara
Copy link
Member

It worked! Looks great! Thank you again! @mogery

@nickscamara
Copy link
Member

/tip $10

Copy link

algora-pbc bot commented Feb 7, 2024

🎉🎈 @mogery has been awarded $10! 🎈🎊

@nickscamara nickscamara merged commit 7fa99a6 into firecrawl:main Feb 7, 2024
@mogery
Copy link
Member Author

mogery commented Feb 7, 2024

Busted on the Confluence test copy paste 🙈 Thank you!

@mogery mogery deleted the mog/salesforce branch February 7, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Salesforce Data Connector
2 participants