Skip to content

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Nov 3, 2021

Description

Update minSdk to 19 in build gradle on four different plugins. Android has breaking changes which mean a number of packages are not compatible with android 4.4.0 or anything below API level 19 (KitKat). see here.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Nov 3, 2021
@russellwheatley russellwheatley changed the title feat!: update android minSdk to 19 for analytics, firestore, dynamic_links, crashlytics & messaging feat!: Update Android minSdk to 19 for analytics, firestore, dynamic_links, crashlytics & messaging Nov 3, 2021
@russellwheatley russellwheatley changed the title feat!: Update Android minSdk to 19 for analytics, firestore, dynamic_links, crashlytics & messaging feat!: Update Android minSdk to 19 for analytics, firestore, dynamic_links & messaging Nov 3, 2021
@Salakar Salakar changed the title feat!: Update Android minSdk to 19 for analytics, firestore, dynamic_links & messaging feat!: update Android minSdk version to 19 as this is required by Firebase Android SDK 29.0.0 Nov 3, 2021
@russellwheatley russellwheatley merged commit da458e2 into master Nov 3, 2021
@russellwheatley russellwheatley deleted the @russell/bump-minSdks branch November 3, 2021 15:47
@firebase firebase locked and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants