Skip to content

Fix JSON literal parsing in VertexAI #6033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Jun 13, 2024

Per b/346811894,

This fixes an issue with the VertexAI SDK failing to decode json literals. More specifically, the fix was applied to generativeai:common with 0.7.1, and this PR bumps said dependency to bring in the change.

Fixes #6028

@daymxn daymxn requested review from rlazo and davidmotson June 13, 2024 16:46
@daymxn daymxn self-assigned this Jun 13, 2024
Copy link
Contributor

github-actions bot commented Jun 13, 2024

Release note changes

The following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from.

Changelogs

firebase-vertexai

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

Unit Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 60d2ef2. ± Comparison against base commit dc30825.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-vertexai

    TypeBase (dc30825)Merge (a0bbd37)Diff
    apk (aggressive)1.31 MB1.31 MB+8 B (+0.0%)
    apk (release)9.30 MB9.30 MB+16 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OaO86oFQjl.html

@daymxn daymxn merged commit c42ba45 into master Jun 13, 2024
@daymxn daymxn deleted the daymon-vertex-bump-genai branch June 13, 2024 17:15
emilypgoogle pushed a commit that referenced this pull request Jun 13, 2024
Per [b/346811894](https://b.corp.google.com/issues/346811894),

This fixes an issue with the VertexAI SDK failing to decode json
literals. More specifically, the fix was applied to
`generativeai:common` with `0.7.1`, and this PR bumps said dependency to
bring in the change.

Fixes #6028
@firebase firebase locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VertexAI JsonDecodingException When requesting a Boolean parameter
3 participants