Skip to content

Adopt custom defaulter and validator interface for webhooks intead of deprecated default #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 23, 2025
Merged

Adopt custom defaulter and validator interface for webhooks intead of deprecated default #3152

merged 8 commits into from
Jan 23, 2025

Conversation

sanketsudake
Copy link
Member

Description

  • Moved all webhooks under webhooks package
  • Adopted CustomDefaulter and CustomValidator interfaces from controller-runtime
  • Removed deprecated DefaultDefaulter and DefaultValidator interfaces
  • Unified implementation code across all webhooks
  • update makefile for manifests generation command

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@sanketsudake
Move webhooks to webhooks package
31d78aa 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
change interface
7d30e4b 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
Change interface methods
e7a6b5b 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
comment debug logs for now
25f294b 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
rename files
ebddf49 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
Fix webhook warnings
933d4f9 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
Update makefile
f905722 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
lint fixes
3801d77 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 42.97189% with 142 lines in your changes missing coverage. Please review.

Project coverage is 44.60%. Comparing base (703613a) to head (3801d77).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/webhook/package.go 38.88% 26 Missing and 7 partials ⚠️
pkg/webhook/function.go 41.02% 18 Missing and 5 partials ⚠️
pkg/webhook/kuberneteswatchtrigger.go 20.68% 23 Missing ⚠️
pkg/webhook/environment.go 40.00% 16 Missing and 2 partials ⚠️
pkg/webhook/messagequeuetrigger.go 39.13% 12 Missing and 2 partials ⚠️
pkg/webhook/httptrigger.go 55.17% 10 Missing and 3 partials ⚠️
pkg/webhook/timetrigger.go 55.17% 10 Missing and 3 partials ⚠️
pkg/webhook/canaryconfig.go 37.50% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3152      +/-   ##
==========================================
+ Coverage   44.54%   44.60%   +0.06%     
==========================================
  Files         237      237              
  Lines       24833    24854      +21     
==========================================
+ Hits        11061    11087      +26     
+ Misses      12347    12339       -8     
- Partials     1425     1428       +3
Flag Coverage Δ
unittests 44.60% <42.97%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanketsudake sanketsudake merged commit fb60a14 into main Jan 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soharab-ic soharab-ic soharab-ic approved these changes

@neha-Gupta1 neha-Gupta1 Awaiting requested review from neha-Gupta1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketsudake @soharab-ic