Skip to content

Use GHCR repo for fetcher image by default #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 16, 2025
Merged

Use GHCR repo for fetcher image by default #3145

merged 3 commits into from
Jan 16, 2025

Conversation

sanketsudake
Copy link
Member

@sanketsudake sanketsudake commented Jan 15, 2025 •
edited
Loading

Description

  • Added imagewithTag template which helps in figuring right image path.
  • Using same for fission-bundle, preupgradecheck, reporter and fetcher image.

Which issue(s) this PR fixes:

Fixes #

Testing

Before changes

helm template  charts/fission-all | grep "fission/"  | grep -v ghcr
          value: "fission/fetcher:v1.21.0-rc1"
          value: "fission/fetcher:v1.21.0-rc1"
        image: fission/pre-upgrade-checks:v1.21.0-rc1

After changes,

helm template  charts/fission-all | grep "fission/"
        image: "ghcr.io/fission/fission-bundle:v1.21.0-rc1"
          value: "ghcr.io/fission/fetcher:v1.21.0-rc1"
        image: "ghcr.io/fission/fission-bundle:v1.21.0-rc1"
          value: "ghcr.io/fission/fetcher:v1.21.0-rc1"
        image: "ghcr.io/fission/fission-bundle:v1.21.0-rc1"
        image: "ghcr.io/fission/fission-bundle:v1.21.0-rc1"
          value: "ghcr.io/fission/keda-kafka-http-connector:v0.17"
          value: "ghcr.io/fission/keda-rabbitmq-http-connector:v0.15"
          value: "ghcr.io/fission/keda-aws-kinesis-http-connector:v0.15"
          value: "ghcr.io/fission/keda-aws-sqs-http-connector:v0.16"
          value: "ghcr.io/fission/keda-nats-streaming-http-connector:v0.18"
          value: "ghcr.io/fission/keda-nats-jetstream-http-connector:v0.9"
          value: "ghcr.io/fission/keda-gcp-pubsub-http-connector:v0.11"
          value: "ghcr.io/fission/keda-redis-http-connector:v0.8"
        image: "ghcr.io/fission/fission-bundle:v1.21.0-rc1"
        image: "ghcr.io/fission/fission-bundle:v1.21.0-rc1"
        image: "ghcr.io/fission/fission-bundle:v1.21.0-rc1"
        image: "ghcr.io/fission/fission-bundle:v1.21.0-rc1"
          image: "ghcr.io/fission/reporter:v1.21.0-rc1"
          image: "ghcr.io/fission/reporter:v1.21.0-rc1"
        image: "ghcr.io/fission/pre-upgrade-checks:v1.21.0-rc1"

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@sanketsudake
Use GHCR repo for fetcher image by default
aa9ce4b 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.53%. Comparing base (a8157e9) to head (cbba305).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3145   +/-   ##
=======================================
  Coverage   44.53%   44.53%           
=======================================
  Files         237      237           
  Lines       24810    24810           
=======================================
  Hits        11048    11048           
  Misses      12340    12340           
  Partials     1422     1422
Flag Coverage Δ
unittests 44.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanketsudake
Fix help template
16c27c7 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
Fix all templates used
cbba305 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake merged commit f44983f into main Jan 16, 2025
11 checks passed
@sanketsudake sanketsudake deleted the fetcher-fix branch January 16, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soharab-ic soharab-ic soharab-ic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketsudake @soharab-ic