Skip to content

PR-3051: Fix download deploy package out of k8s cluster #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2025
Merged

PR-3051: Fix download deploy package out of k8s cluster #3136

merged 3 commits into from
Jan 13, 2025

Conversation

soharab-ic
Copy link
Contributor

@soharab-ic soharab-ic commented Jan 10, 2025 •
edited
Loading

Description

Original author for PR #3051 is inactive. Therefore created this duplicate PR with additional fixes.

Which issue(s) this PR fixes:

Fixes #

Testing

Verified these two scenarios:

  • Deployment URL belongs to storagesvc.
  • Deployment URL is outside k8s cluster.

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 44.53%. Comparing base (4067880) to head (2d0b59e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/fission-cli/cmd/package/util/util.go 41.66% 12 Missing and 2 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3136   +/-   ##
=======================================
  Coverage   44.52%   44.53%           
=======================================
  Files         237      237           
  Lines       24788    24810   +22     
=======================================
+ Hits        11038    11048   +10     
- Misses      12330    12340   +10     
- Partials     1420     1422    +2
Flag Coverage Δ
unittests 44.53% <41.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soharab-ic soharab-ic mentioned this pull request Jan 10, 2025
Closed
5 tasks
sanketsudake
sanketsudake reviewed Jan 11, 2025
View reviewed changes
lx1036 and others added 3 commits January 13, 2025 12:07
@lx1036 @soharab-ic
Fix download deploy package out of k8s cluster
27435ea 
Signed-off-by: LiuXiang <lx1036@126.com>
@soharab-ic
Fix pkg getdeploy cli command to fetch pkgs stored in storagesvc and …
36fdb9e 
…remote pkgs

Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
Instead of Contains, parse url and check path for better validation
2d0b59e 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic soharab-ic force-pushed the feature/fix-pkg-getdeloy branch from 917b2a5 to 2d0b59e Compare January 13, 2025 06:44
@sanketsudake sanketsudake merged commit a8157e9 into main Jan 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soharab-ic @sanketsudake @lx1036