Skip to content

Add path safety fixes #3061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2024
Merged

Add path safety fixes #3061

merged 3 commits into from
Nov 18, 2024

Conversation

sanketsudake
Copy link
Member

Description

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@sanketsudake
Add path safety fixes
0eaeb25 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.83333% with 38 lines in your changes missing coverage. Please review.

Project coverage is 44.54%. Comparing base (82c0fba) to head (a823e6e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/fetcher/fetcher.go 5.55% 13 Missing and 4 partials ⚠️
pkg/executor/executortype/poolmgr/gp.go 0.00% 9 Missing ⚠️
pkg/builder/builder.go 0.00% 5 Missing and 1 partial ⚠️
pkg/utils/utils.go 53.84% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3061      +/-   ##
==========================================
- Coverage   44.58%   44.54%   -0.04%     
==========================================
  Files         236      236              
  Lines       24695    24731      +36     
==========================================
+ Hits        11010    11017       +7     
- Misses      12285    12308      +23     
- Partials     1400     1406       +6
Flag Coverage Δ
unittests 44.54% <20.83%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanketsudake
minor changes
259fef6 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
revert test_huge_response test
a823e6e 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake merged commit 59267e3 into main Nov 18, 2024
10 checks passed
@sanketsudake sanketsudake deleted the path-fixes branch January 1, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soharab-ic soharab-ic soharab-ic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketsudake @soharab-ic