Skip to content

Remove unreachable code #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

Remove unreachable code #3039

merged 1 commit into from
Oct 11, 2024

Conversation

soharab-ic
Copy link
Contributor

@soharab-ic soharab-ic commented Oct 11, 2024 •
edited
Loading

Description

  • Remove unreachable code from fission pkg info and fission pkg rebuild command code.

Which issue(s) this PR fixes:

Fixes #

Testing

$ fission pkg info --name test

Options:
  --name=''   Package name

Global Options:
  --verbosity=1 (-v)   CLI verbosity (0 is quiet, 1 is the default, 2 is verbose)
  --kube-context=''    Kubernetes context to be used for the execution of Fission commands
  --namespace='' (-n)  If present, the namespace scope for this CLI request

Usage:
  fission package info [options]

Error: error finding package test: packages.fission.io "test" not found
$ fission pkg rebuild --name test

Options:
  --name=''   Package name

Global Options:
  --verbosity=1 (-v)   CLI verbosity (0 is quiet, 1 is the default, 2 is verbose)
  --kube-context=''    Kubernetes context to be used for the execution of Fission commands
  --namespace='' (-n)  If present, the namespace scope for this CLI request

Usage:
  fission package rebuild [options]

Error: package test not found: packages.fission.io "test" not found

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@soharab-ic
Remove unreachable code from fission-cli
78f9b74 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.97%. Comparing base (c43f6fe) to head (78f9b74).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/fission-cli/cmd/package/rebuild.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3039   +/-   ##
=======================================
  Coverage   45.97%   45.97%           
=======================================
  Files         236      236           
  Lines       19580    19576    -4     
=======================================
  Hits         9001     9001           
+ Misses       9177     9175    -2     
+ Partials     1402     1400    -2
Flag Coverage Δ
unittests 45.97% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanketsudake sanketsudake merged commit 2d70c9d into main Oct 11, 2024
10 checks passed
@sanketsudake sanketsudake deleted the unreachable-code branch January 1, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soharab-ic @sanketsudake