Description

• If we create an environment with invalid values in manifest file then environment creation will fail. We will see the respective logs in executor. No issues here.
• Now if we delete that environment then poolmgr cleanup service is called and return statement in this service breaks the Go routine.

Which issue(s) this PR fixes:

Fixes #

Testing

• Create environment manifest using fission spec command.

$ fission spec init
$ fission env create --name go --image ghcr.io/fission/go-env --builder ghcr.io/fission/go-builder --spec

• Now edit the specs/env-go.yaml file and use an invalid container name for runtime. Valid name = envName
  spec.runtime.container.name = invalid

apiVersion: fission.io/v1
kind: Environment
metadata:
  creationTimestamp: null
  name: go
spec:
  builder:
    command: build
    container:
      name: ""
      resources: {}
    image: ghcr.io/fission/go-builder
  imagepullsecret: ""
  keeparchive: false
  poolsize: 3
  resources: {}
  runtime:
    container:
      name: "invalid"
      resources: {}
    image: ghcr.io/fission/go-env
  version: 3

• Now, run fission spec apply. The poolmgr deployment will not be created but builder deployment will be created.
• Run fission spec destroy to delete the environment.
• Fix above manifest file and run fission spec apply again. Poolmgr deployment is not created because the Go routine responsible for creating deployment was killed when we ran fission spec destroy. Create any other environment and you will see the issue.
• Now apply this fix and follow the steps again.

Checklist:

• I ran tests as well as code linting locally to verify my changes.
• I have done manual verification of my changes, changes working as expected.
• I have added new tests to cover my changes.
• My changes follow contributing guidelines of Fission.
• I have signed all of my commits.