Skip to content

Upgraded to Go latest version 1.23.1 #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 30, 2024
Merged

Upgraded to Go latest version 1.23.1 #3027

merged 4 commits into from
Sep 30, 2024

Conversation

soharab-ic
Copy link
Contributor

Description

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@soharab-ic
Upgraded to latest go version 1.23.1
2ab1648 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
Fix lint failure
3f1fdeb 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
Fix lint failures
f378910 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.43%. Comparing base (2db9db0) to head (a313b03).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/executor/executortype/poolmgr/gp.go 0.00% 2 Missing ⚠️
pkg/mqtrigger/messageQueue/kafka/consumer.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3027   +/-   ##
=======================================
  Coverage   44.43%   44.43%           
=======================================
  Files         236      236           
  Lines       24702    24702           
=======================================
  Hits        10976    10976           
  Misses      12320    12320           
  Partials     1406     1406
Flag Coverage Δ
unittests 44.43% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sanketsudake
sanketsudake reviewed Sep 30, 2024
View reviewed changes
sanketsudake
sanketsudake reviewed Sep 30, 2024
View reviewed changes
@soharab-ic
Remove unnecessary formatting
a313b03 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@sanketsudake sanketsudake merged commit 9bdac9a into main Sep 30, 2024
10 checks passed
@sanketsudake sanketsudake deleted the upgrade-go-1.23.1 branch September 30, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soharab-ic @sanketsudake