Skip to content

Fixed: Print pod log error when response status is 404 returned by te… #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

waitstory
Copy link
Contributor

@waitstory waitstory commented Sep 23, 2024

Description

When I tested the function under the default namespace, the response status returned was 404. At this point, the pod log corresponding to the function is queried, but it is always queried under the 'fission-function' namespace, which results in an error because the pod cannot be found.

Which issue(s) this PR fixes:

Fixes #3014

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

…st function

Signed-off-by: waitstory <waitstory@163.com>
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 44.33%. Comparing base (93869d3) to head (e9422b9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/fission-cli/util/util.go 0.00% 13 Missing ⚠️
pkg/fission-cli/logdb/kubernetes_log.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3021      +/-   ##
==========================================
- Coverage   44.36%   44.33%   -0.03%     
==========================================
  Files         236      236              
  Lines       24650    24659       +9     
==========================================
- Hits        10936    10933       -3     
- Misses      12309    12320      +11     
- Partials     1405     1406       +1     
Flag Coverage Δ
unittests 44.33% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanketsudake sanketsudake merged commit b8f746c into fission:main Sep 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print pod log error when response status is 404 returned by test function
3 participants