Skip to content

Fix error handling in package update logic implementation #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

elastic17
Copy link
Contributor

@elastic17 elastic17 commented Sep 11, 2024

Description

There is a problem with error handling when updating packages through fission CLI, and there is redundancy in error handling. One of the errors should be removed.

image

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@soharab-ic
Copy link
Contributor

Please sign your commit.
signing-commits

@sanketsudake sanketsudake merged commit 1f41de9 into fission:main Sep 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants