Skip to content

Add resource namespace to logger #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

markretallack
Copy link
Contributor

Description

This change adds the fission-resource-namespace.envs helper to the logger (fluentbit) helm charts so that FISSION_RESOURCE_NAMESPACES is correctly exposed to the logger pod. This allows the logger to capture logs from functions that are running in non-default namespaces that are defined in additionalFissionNamespaces.

Which issue(s) this PR fixes:

None

Testing

Deployed into EKS and checked that the logs are correctly captured from the non-default namespaces into influxdb.

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@sanketsudake sanketsudake merged commit ce49eb3 into fission:main Aug 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants