Skip to content

Fix: Message queue trigger update #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 16, 2024
Merged

Fix: Message queue trigger update #2991

merged 4 commits into from
Aug 16, 2024

Conversation

soharab-ic
Copy link
Contributor

Description

This PR fixes a couple of issues:

  • Handle mqt update which is ignored in mqtManager.
  • Update scalemanager to handle scenarios when mqtkind is updated from keda to fission and vice-versa.
  • Fix short circuit evaluation in mqt update which may fail the metadata update.

Which issue(s) this PR fixes:

Fixes #

Testing

  • Updated mqtkind from fission to keda and verified that scaledobject, triggerauthentications and deployment objects are being created.
  • Updated mqtkind from keda to fission and verified that scaledobject, triggerauthentications and deployment objects are being deleted.
  • Verified mqt.Spec.Metadata is being updated.

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@soharab-ic
Handle mqt update
907a1a8 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
Update scalemanager to support mqtkind update
2e22a8c 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
Short circuit evalution may fail metadata update
ff63f7f 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
Updated mqtmanager test
f6be45d 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 12.17391% with 101 lines in your changes missing coverage. Please review.

Project coverage is 44.35%. Comparing base (cb3a765) to head (f6be45d).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/mqtrigger/scalermanager.go 9.52% 55 Missing and 2 partials ⚠️
pkg/mqtrigger/mqtmanager.go 16.00% 41 Missing and 1 partial ⚠️
pkg/fission-cli/cmd/mqtrigger/update.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2991      +/-   ##
==========================================
- Coverage   44.47%   44.35%   -0.12%     
==========================================
  Files         236      236              
  Lines       24535    24621      +86     
==========================================
+ Hits        10911    10920       +9     
- Misses      12217    12293      +76     
- Partials     1407     1408       +1
Flag Coverage Δ
unittests 44.35% <12.17%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanketsudake sanketsudake merged commit 26f9648 into main Aug 16, 2024
10 checks passed
@sanketsudake sanketsudake deleted the mqt-update branch September 26, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soharab-ic @sanketsudake