Remove redundant code and simplify input parsing during HTTPTrigger creation #2990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanketsudake
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1、Even if the user does not set the flagkey. HtMethod field, there will still be a default value GET, so the following judgment logic is currently redundant. Personally, I think it is more appropriate to replace the return error with a log prompt or delete it.
2、Both createIngress and host are only used for parsing user input and do not perform any other operations. They can be directly parsed during the construction of the HTTPTrigger CR.
3、The parsing of the KeepPrefix field below is redundant
Which issue(s) this PR fixes:
Fixes #
Testing
Checklist: