Skip to content

Fixed mqtrigger scaling issue #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 9, 2024
Merged

Fixed mqtrigger scaling issue #2986

merged 3 commits into from
Aug 9, 2024

Conversation

soharab-ic
Copy link
Contributor

@soharab-ic soharab-ic commented Aug 7, 2024 •
edited
Loading

Description

  • Creating large number of MQTs (10+) was making mqtrigger-kafka pod very slow.
  • Due to this new MQTs were not creating and trigger processing for old MQTs was also not working.
  • We have added two metrics for more visibility.
  • fission_mqt_inprocess for total number of MQTs in active processing.
  • fission_mqt_status for status of an individual trigger, 1 if processing otherwise 0..

Which issue(s) this PR fixes:

Fixes #

Testing

  • Tested on kind cluster by creating 100 MQTs.
  • All 100 MQTs were created under five minutes and trigger processing was also working.

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@soharab-ic
Fixed mqtrigger scaling issue
e2101c1 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic soharab-ic requested a review from sanketsudake August 7, 2024 10:28
@codecov Codecov
Copy link

codecov bot commented Aug 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.88235% with 32 lines in your changes missing coverage. Please review.

Project coverage is 44.66%. Comparing base (35276a5) to head (7953fd0).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/mqtrigger/messageQueue/kafka/kafka.go 0.00% 20 Missing ⚠️
pkg/mqtrigger/metrics.go 20.00% 8 Missing ⚠️
pkg/mqtrigger/messageQueue/kafka/consumer.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2986      +/-   ##
==========================================
- Coverage   44.70%   44.66%   -0.04%     
==========================================
  Files         236      236              
  Lines       24306    24405      +99     
==========================================
+ Hits        10865    10901      +36     
- Misses      12032    12094      +62     
- Partials     1409     1410       +1
Flag Coverage Δ
unittests 44.66% <5.88%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sanketsudake
sanketsudake reviewed Aug 7, 2024
View reviewed changes
@soharab-ic
Resolve review comments
eaa3984 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
Set goreleaser version to v1
7953fd0 
Remove armv7 references from goreleaser file

Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@sanketsudake sanketsudake merged commit 90d781c into main Aug 9, 2024
11 checks passed
@sanketsudake sanketsudake deleted the mqtrigger-scaling-issue branch September 26, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soharab-ic @sanketsudake