Skip to content

Creating large number of MQTs takes time #2984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 12, 2024
Merged

Creating large number of MQTs takes time #2984

merged 4 commits into from
Aug 12, 2024

Conversation

soharab-ic
Copy link
Contributor

@soharab-ic soharab-ic commented Aug 5, 2024 •
edited
Loading

Description

  • Creating 100 MQTs takes around 5 minutes of time.
  • This PR introduces workqueue to be used by MessageQueueTriggerManager for create, update and delete of MQTs.
  • For create and update, four workers will be running.
  • This fix will bring down 100 MQTs creation time from 5 minutes to 1-1.5 minutes.

Which issue(s) this PR fixes:

Fixes #

Testing

  • Created 100 MQTs which took around 1-1.5 minutes of time.
  • Trigger processing was also working..

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@soharab-ic soharab-ic requested a review from sanketsudake August 5, 2024 08:12
@codecov Codecov
Copy link

codecov bot commented Aug 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 10.41667% with 172 lines in your changes missing coverage. Please review.

Project coverage is 44.46%. Comparing base (90d781c) to head (5a0af96).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/mqtrigger/mqtmanager.go 10.98% 162 Missing ⚠️
cmd/fission-bundle/mqtrigger/mqtrigger.go 0.00% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2984      +/-   ##
==========================================
- Coverage   44.67%   44.46%   -0.22%     
==========================================
  Files         236      236              
  Lines       24405    24546     +141     
==========================================
+ Hits        10904    10914      +10     
- Misses      12092    12221     +129     
- Partials     1409     1411       +2
Flag Coverage Δ
unittests 44.46% <10.41%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soharab-ic
Implementing workqueue for MessageQueueTriggers
c625ffa 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
Fixing some issues with informers and deleteQueue
b608aaa 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
Fixing fission_mqt_created metrics
800436b 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
Rebase with main
5a0af96 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic soharab-ic changed the title mqtrigger-kafka pod gets stuck when large number of MQTs are created Creating large number of MQTs takes time Aug 12, 2024
@sanketsudake sanketsudake merged commit 13abb2e into main Aug 12, 2024
10 checks passed
@sanketsudake sanketsudake deleted the mqt-scaling branch September 26, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soharab-ic @sanketsudake