Removing comments from the environment creation process and eliminating redundant code during the update process #2983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanketsudake
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(1) There are misleading comments in the implementation of parameter parsing for creating environment through CLI. The specific content is shown in the following figure. Currently, the parameter EnvVersion is set to a default value of 3. When this parameter is not set when creating env, it will be set to 3. Only when manually setting -- version to 0 will this logic be followed. The current annotations do not match the current implementation and are misleading. It is recommended to delete them.
(2) There is redundant code in the specific implementation of updating the environment through CLI, as shown in the following figure:
Which issue(s) this PR fixes:
Fixes #
Testing
Checklist: