added http status code error handling to DownloadUrl function #2959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did all this. Let me know if something is still missing. |
|
@jaynis Please follow this Github doc for signing your commit. E.g. These are the signed commits. Click on the verified button. |
Signed-off-by: jaynis <kranz.jannis@googlemail.com>
|
Sorry I confused signing a commit with signing it off. Now I have properly signed it and you can see the "verified" bubble on my commit. |
soharab-ic
approved these changes
Jun 19, 2024
sanketsudake
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds http status code error handling to the
DownloadUrlutils functions so that it returns an error if the received response has a non-successful status code. This again enables the fetcher sidecar container to error out if the requested package cannot be served by the storage service (e.g. indicated by status code 404).Which issue(s) this PR fixes:
Fixes #2958
Testing
Please note the error below is highly expected because this PR is about adding errors where they were missing before.