Set goreleaser version to v1 for CI tests #2956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Latest goreleaser version v2 has some breaking changes. Due to this CI tests failed. Therefore, setting goreleaser version to v1. ``` Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2956 +/- ##
=======================================
Coverage 44.57% 44.57%
=======================================
Files 236 236
Lines 24216 24216
=======================================
Hits 10795 10795
Misses 12019 12019
Partials 1402 1402
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sanketsudake
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default goreleaser-action
v5.0.0sets goreleaser version tolatest. Latest goreleaser version has some breaking changes and involves major version change to v2.Due to this, we are seeing this issue while building
fission-cliThis PR sets the goreleaser version to
v1.Which issue(s) this PR fixes:
Fixes #
Testing
Checklist: