Skip to content

Fix: Remove variables field from .goreleaser.yml #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

soharab-ic
Copy link
Contributor

Description

  • Failed to run make skaffold-prebuild command.
$ make skaffold-prebuild 
  • starting build...
  ⨯ build failed after 0s                    error=yaml: unmarshal errors:
  line 15: field variables not found in type config.Project
make: *** [Makefile:115: skaffold-prebuild] Error 1

Which issue(s) this PR fixes:

Fixes #

Testing

$ make skaffold-prebuild 
  • starting build...
  • loading                                          path=.goreleaser.yml
  • skipping validate...
  • loading environment variables
  • getting and validating git state
    • couldn't find any tags before "v0.0.0"
    • git state                                      commit=0e739a1bf0b3c5c98ead479c12b721314ad69b7a branch=fix-goreleaser current_tag=v0.0.0 previous_tag=<unknown> dirty=true
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
  • partial
  • snapshotting
    • building snapshot...                           version=v0.0.0
  • running before hooks
    • running                                        hook=go mod tidy
  • checking distribution directory
    • cleaning dist
  • setting up metadata
  • storing release metadata
    • writing                                        file=dist/metadata.json
  • loading go mod information
  • build prerequisites
  • writing effective config file
    • writing                                        config=dist/config.yaml
  • building binaries
    • partial build                                  match=target=linux_amd64
    • partial build                                  match=target=linux_amd64
    • partial build                                  match=target=linux_amd64
    • partial build                                  match=target=linux_amd64
    • partial build                                  match=target=linux_amd64
    • partial build                                  match=target=linux_amd64
    • building                                       binary=dist/reporter_linux_amd64_v1/reporter
    • building                                       binary=dist/builder_linux_amd64_v1/builder
    • building                                       binary=dist/pre-upgrade-checks_linux_amd64_v1/pre-upgrade-checks
    • building                                       binary=dist/fetcher_linux_amd64_v1/fetcher
    • building                                       binary=dist/fission-bundle_linux_amd64_v1/fission-bundle
    • building                                       binary=dist/fission-cli_linux_amd64_v1/fission
    • took: 2s
  • storing artifacts metadata
    • writing                                        file=dist/artifacts.json
  • build succeeded after 2s
  • thanks for using goreleaser!
'cmd/builder/Dockerfile' -> 'dist/builder_linux_amd64_v1/Dockerfile'
'cmd/fetcher/Dockerfile' -> 'dist/fetcher_linux_amd64_v1/Dockerfile'
'cmd/fission-bundle/Dockerfile' -> 'dist/fission-bundle_linux_amd64_v1/Dockerfile'
'cmd/reporter/Dockerfile' -> 'dist/reporter_linux_amd64_v1/Dockerfile'
'cmd/preupgradechecks/Dockerfile' -> 'dist/pre-upgrade-checks_linux_amd64_v1/Dockerfile'

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

```
Remove variables field from .goreleaser.yml
```

Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic soharab-ic requested a review from sanketsudake June 3, 2024 10:38
@sanketsudake sanketsudake merged commit ade2daa into main Jun 3, 2024
@sanketsudake sanketsudake deleted the fix-goreleaser branch June 26, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants