Skip to content

Conversation

robert-cronin
Copy link
Contributor

@robert-cronin robert-cronin commented May 27, 2024

Description

This PR resolves an issue with Fission where the existing MutatingWebhookConfiguration conflicts with other packages like Rancher. The name of the MutatingWebhookConfiguration was changed from mutating-webhook-configuration to fission-mutating-webhooks to avoid conflicts.

Which issue(s) this PR fixes:

Fixes #2920

Testing

Modified the mutating webhook configuration name and verified that Fission installs without errors on kind using skaffold:

➜  fission git:(fix/helm-webhook-conflict-rancher) k get MutatingWebhookConfiguration
NAME                        WEBHOOKS   AGE
fission-mutating-webhooks   1          47s
➜  fission git:(fix/helm-webhook-conflict-rancher) helm list -n fission -oyaml
- app_version: v1.20.1
  chart: fission-all-v1.20.1
  name: fission
  namespace: fission
  revision: "1"
  status: deployed
  updated: 2024-05-27 15:07:30.75335639 +1000 AEST

Note: there were some errors in the testing process but these appear to occur without these changes as well so could just be my system.

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@robert-cronin robert-cronin force-pushed the fix/helm-webhook-conflict-rancher branch from ef62dd0 to 1a48988 Compare May 27, 2024 05:15
@sanketsudake
Copy link
Member

@Mergifyio rebase

Copy link

mergify bot commented May 27, 2024

rebase

✅ Branch has been successfully rebased

@sanketsudake sanketsudake force-pushed the fix/helm-webhook-conflict-rancher branch from 1a48988 to 4a690fb Compare May 27, 2024 05:58
@sanketsudake sanketsudake merged commit c6d0182 into fission:main May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fission helm conflicts with Rancher
2 participants