Skip to content

Fix: ValidatingWebhookConfiguration conflict #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2024

Conversation

robert-cronin
Copy link
Contributor

Description

This PR resolves an issue with Fission where the existing ValidatingWebhookConfiguration conflicts with other packages like MetalLB. The name of the ValidatingWebhookConfiguration was changed from validating-webhook-configuration to fission-validating-webhooks to avoid conflicts.

Which issue(s) this PR fixes:

Fixes #2825

Testing

Modified the webhook configuration name and verified that Fission installs without errors on kind using skaffold:

➜  fission git:(main) ✗ k get ValidatingWebhookConfiguration
NAME                          WEBHOOKS   AGE
fission-validating-webhooks   7          39s
➜  fission git:(main) ✗ helm list -n fission -oyaml         
- app_version: v1.20.1
  chart: fission-all-v1.20.1
  name: fission
  namespace: fission
  revision: "1"
  status: deployed
  updated: 2024-05-26 21:00:09.761054139 +1000 AEST

Note: there were some errors in the testing process but these appear to occur without these changes as well so could just be my system.

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@robert-cronin
Copy link
Contributor Author

If there are any aspects where I haven't followed best practices, please let me know so I can make the necessary adjustments. Thank you!

@sanketsudake sanketsudake merged commit d8fe37e into fission:main May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fission tries to change ValidatingWebhookConfiguration on microk8s
2 participants