Skip to content

Fix fission check command doesnt work for namespace other than fission #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2024
Merged

Fix fission check command doesnt work for namespace other than fission #2932

merged 3 commits into from
May 7, 2024

Conversation

soharab-ic
Copy link
Contributor

@soharab-ic soharab-ic commented May 6, 2024 •
edited
Loading

Description

fission check command does not work outside of "fission" namespace. If user provides namespace then use it for running fission check command otherwise use fission as default namespace.

Which issue(s) this PR fixes:

Fixes #2924

Testing

  • Fission installed in fission namespace.
$ fission check
fission-services
--------------------
√ executor is running fine
√ router is running fine
√ storagesvc is running fine
√ webhook is running fine

fission-version
--------------------
√ fission is up-to-date
  • Fission installed in check namespace.
$ fission check
fission-services
--------------------
× failed to get executor deployment status
× failed to get router deployment status
× failed to get storagesvc deployment status
Error: Error found: failed to get webhook deployment status
× failed to get webhook deployment status

fission-version
--------------------
√ fission is up-to-date

$ fission check --namespace check
fission-services
--------------------
√ executor is running fine
√ router is running fine
√ storagesvc is running fine
√ webhook is running fine

fission-version
--------------------
√ fission is up-to-date

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@soharab-ic
Fix fission check command which does not work outside of fission …
79babc0 
…namespace

If user provide namespace then use it for running `fission check` command.
If user does not provide namespace then use `fission` as default namespace.

Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@sanketsudake sanketsudake self-requested a review May 6, 2024 06:37
sanketsudake
sanketsudake requested changes May 6, 2024
View reviewed changes
soharab-ic added 2 commits May 6, 2024 15:35
@soharab-ic
Resolve review comments
7c75209 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
Update go version to 1.22.2
883bdc2 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@sanketsudake sanketsudake changed the title Fix fission check command which does not work outside of fission … Fix fission check command doesnt work for namespace other than fission May 7, 2024
@sanketsudake sanketsudake merged commit 241983d into fission:main May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"fission check" does not work outside of "fission" namespace
2 participants
@soharab-ic @sanketsudake