Skip to content

fix: close tmp file in fission CLI WriteArchiveToFile #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2024
Merged

fix: close tmp file in fission CLI WriteArchiveToFile #2931

merged 1 commit into from
May 7, 2024

Conversation

testwill
Copy link
Contributor

Description

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@sanketsudake
Copy link
Member

@Mergifyio rebase

@mergify Mergify
Copy link

mergify bot commented May 7, 2024

rebase

✅ Branch has been successfully rebased

@sanketsudake sanketsudake self-requested a review May 7, 2024 06:43
@sanketsudake sanketsudake changed the title fix: close tmp file fix: close tmp file in fission CLI WriteArchiveToFile May 7, 2024
@sanketsudake sanketsudake merged commit 08c662b into fission:main May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@testwill @sanketsudake