Skip to content

Add kubernetes QPS and Burst limit configuration #2899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

sanketsudake
Copy link
Member

Description

Added configurable kubernetes client limits burst and QPS
Default QPS 200 and burst 500.

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (82b2848) 46.71% compared to head (e2aa326) 46.70%.

Files Patch % Lines
pkg/crd/client.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2899      +/-   ##
==========================================
- Coverage   46.71%   46.70%   -0.01%     
==========================================
  Files         215      215              
  Lines       22519    22542      +23     
==========================================
+ Hits        10519    10529      +10     
- Misses      10645    10658      +13     
  Partials     1355     1355              
Flag Coverage Δ
unittests 46.70% <43.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants